skylab/MasterPassword
2
0
Fork 0
Code Releases Activity

bzero is nonstandard. Replace with memset_s.

Browse Source
This commit is contained in:
Maarten Billemont
2017-09-24 13:14:16 -04:00
parent 0a024b2594
commit fafe56166e
5 changed files with 16 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
platform-independent/cli-c/cli/bcrypt.h
View File

@@ -186,10 +186,10 @@ bcrypt_hashpass(const char *key, const uint8_t *salt, char *encrypted,
snprintf( encrypted, 8, "$2%c$%2.2u$", minor, logr );
encode_base64( encrypted + 7, csalt, BCRYPT_MAXSALT );
encode_base64( encrypted + 7 + 22, ciphertext, 4 * BCRYPT_WORDS - 1 );
bzero( &state, sizeof( state ) );
bzero( ciphertext, sizeof( ciphertext ) );
bzero( csalt, sizeof( csalt ) );
bzero( cdata, sizeof( cdata ) );
memset_s( &state, sizeof state, 0, sizeof state );
memset_s( ciphertext, sizeof ciphertext, 0, sizeof ciphertext );
memset_s( csalt, sizeof csalt, 0, sizeof csalt );
memset_s( cdata, sizeof cdata, 0, sizeof cdata );
return 0;
inval:

2
platform-independent/cli-c/cli/mpw-cli-util.c
View File

@@ -128,7 +128,7 @@ const char *mpw_getpass(const char *prompt) {
return NULL;
password = strdup( answer );
bzero( answer, strlen( answer ) );
memset_s( answer, strlen( answer ), 0, strlen( answer ) );
return password;
}

3
platform-independent/cli-c/cli/mpw-cli.c
View File

@@ -272,7 +272,8 @@ void cli_free(Arguments *args, Operation *operation) {
void cli_args(Arguments *args, Operation *operation, const int argc, char *const argv[]) {
for (int opt; (opt = getopt( argc, argv, "u:U:m:M:t:P:c:a:p:C:f:F:R:vqh" )) != EOF; optarg? bzero( optarg, strlen( optarg ) ): NULL)
for (int opt; (opt = getopt( argc, argv, "u:U:m:M:t:P:c:a:p:C:f:F:R:vqh" )) != EOF;
optarg? memset_s( optarg, strlen( optarg ), 0, strlen( optarg ) ): 0)
switch (opt) {
case 'u':
args->fullName = optarg && strlen( optarg )? strdup( optarg ): NULL;